Skip to content

Ignore generated release artifacts - #245

Merged
andrew merged 1 commit into
mainfrom
ignore-release-artifacts
Nov 10, 2026
Merged

andrew merged 1 commit into
mainfrom
ignore-release-artifacts

Conversation

@andrew

@andrew andrew commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

GoReleaser creates dist/ before compiling, which makes Git report a modified working tree and embeds vcs.modified=true in the binaries. Ignore the root output directory so builds from unchanged source retain clean VCS metadata.

Summary by CodeRabbit

  • Chores
    • Updated repository housekeeping so generated build output is excluded from version control. This does not change any user-facing features or behavior.

Copilot AI balanced review requested due to automatic review settings November 10, 2026 09:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The root .gitignore now excludes the /dist/ directory.

Changes: Root dist ignore rule

Layer / File(s) Summary
Add root dist exclusion
.gitignore
The ignore rules now exclude the root /dist/ directory.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Possibly related PRs

  • git-pkgs/brief#233: Ignoring root dist/ files can affect the Git changed-file results used by this PR’s filtering.

Suggested labels: go

Merge Risk: Minimal · up to 40f60

Generated root release artifacts will be ignored. No merge-blocking issue is identified.

Architecture risk: Low · up to 40f60

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .gitignore: Added /dist/ to the ignore rules.
Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the change: ignoring the generated root dist/ release artifacts.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 71a3f87b-e77e-4d70-a1bb-440a7654dbcd
Commits

Reviewing files that changed from the base of the PR and between 81b819f and 40f603f.

Files selected for processing: 1

  • .gitignore

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@andrew
andrew merged commit bcd59a9 into main Nov 10, 2026
10 checks passed
@andrew
andrew deleted the ignore-release-artifacts branch November 10, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants